Changeset 2115 for box/trunk/lib/common/EventWatchFilesystemObject.cpp

Timestamp:

28/03/2008 22:18:44 (4 years ago)

Author:

chris

Message:

Improve logging with macros that consistently output strerror(errno) and
errno, replacing almost all use of strerror() in the main code.

Log a more detailed error message before throwing an exception for some
more system call failures.

Make FileStream? store its filename on all platforms, not just Windows.

Wrap some long lines at less than 80 characters to improve readability.

Fix some minor violations of coding standard (white space) and a typo
in a comment.

File:

• box/trunk/lib/common/EventWatchFilesystemObject.cpp (modified) (5 diffs)

box/trunk/lib/common/EventWatchFilesystemObject.cpp

@@ -27 +27 @@
 //
 // Function
-//              Name:    EventWatchFilesystemObject::EventWatchFilesystemObject(const char *)
-//              Purpose: Constructor -- opens the file object
-//              Created: 12/3/04
+//      Name:    EventWatchFilesystemObject::EventWatchFilesystemObject
+//               (const char *)
+//      Purpose: Constructor -- opens the file object
+//      Created: 12/3/04
 //
 // --------------------------------------------------------------------------
@@ -40 +41 @@
         if(mDescriptor == -1)
         {
-                BOX_ERROR("EventWatchFilesystemObject: "
-                        "Failed to open file '" << Filename << "': " <<
-                        strerror(errno));
+                BOX_LOG_SYS_ERROR("EventWatchFilesystemObject: "
+                        "Failed to open file '" << Filename << "'");
                 THROW_EXCEPTION(CommonException, OSFileOpenError)
         }
@@ -54 +54 @@
 //
 // Function
-//              Name:    EventWatchFilesystemObject::~EventWatchFilesystemObject()
-//              Purpose: Destructor
-//              Created: 12/3/04
+//      Name:    EventWatchFilesystemObject::~EventWatchFilesystemObject()
+//      Purpose: Destructor
+//      Created: 12/3/04
 //
 // --------------------------------------------------------------------------
@@ -71 +71 @@
 //
 // Function
-//              Name:    EventWatchFilesystemObject::EventWatchFilesystemObject(const EventWatchFilesystemObject &)
-//              Purpose: Copy constructor
-//              Created: 12/3/04
+//      Name:    EventWatchFilesystemObject::EventWatchFilesystemObject
+//               (const EventWatchFilesystemObject &)
+//      Purpose: Copy constructor
+//      Created: 12/3/04
 //
 // --------------------------------------------------------------------------
-EventWatchFilesystemObject::EventWatchFilesystemObject(const EventWatchFilesystemObject &rToCopy)
+EventWatchFilesystemObject::EventWatchFilesystemObject(
+        const EventWatchFilesystemObject &rToCopy)
         : mDescriptor(::dup(rToCopy.mDescriptor))
 {
@@ -90 +92 @@
 //
 // Function
-//              Name:    EventWatchFilesystemObject::FillInKEvent(struct kevent &, int)
-//              Purpose: For WaitForEvent
-//              Created: 12/3/04
+//      Name:    EventWatchFilesystemObject::FillInKEvent(struct kevent &, int)
+//      Purpose: For WaitForEvent
+//      Created: 12/3/04
 //
 // --------------------------------------------------------------------------
-void EventWatchFilesystemObject::FillInKEvent(struct kevent &rEvent, int Flags) const
+void EventWatchFilesystemObject::FillInKEvent(struct kevent &rEvent,
+        int Flags) const
 {
-        EV_SET(&rEvent, mDescriptor, EVFILT_VNODE, EV_CLEAR, NOTE_DELETE | NOTE_WRITE, 0, (void*)this);
+        EV_SET(&rEvent, mDescriptor, EVFILT_VNODE, EV_CLEAR,
+                NOTE_DELETE | NOTE_WRITE, 0, (void*)this);
 }
 #else
-void EventWatchFilesystemObject::FillInPoll(int &fd, short &events, int Flags) const
+void EventWatchFilesystemObject::FillInPoll(int &fd, short &events,
+        int Flags) const
 {
         THROW_EXCEPTION(CommonException, KQueueNotSupportedOnThisPlatform)