Changeset 2194

Timestamp:

19/06/2008 08:43:31 (4 years ago)

Author:

chris

Message:

Larger buffer size for extended attributes, and better debugging.

File:

• box/trunk/lib/backupclient/BackupClientFileAttributes.cpp (modified) (2 diffs)

box/trunk/lib/backupclient/BackupClientFileAttributes.cpp

@@ -466 +466 @@
 {
 #ifdef HAVE_SYS_XATTR_H
-        int listBufferSize = 1000;
+        int listBufferSize = 10000;
         char* list = new char[listBufferSize];
 
@@ -562 +562 @@
                         outputBlock.ResizeBlock(xattrSize);
                 }
-                else if(listSize<0 && errno!=EOPNOTSUPP && errno!=EACCES)
-                {
-                        THROW_EXCEPTION(CommonException, OSFileError);
+                else if(listSize<0)
+                {
+                        if(errno == EOPNOTSUPP || errno == EACCES)
+                        {
+                                // fail silently
+                        }
+                        else if(errno == ERANGE)
+                        {
+                                BOX_ERROR("Failed to read extended "
+                                        "attributes of " << Filename <<
+                                        ": buffer too small, not backed up");
+                        }
+                        else
+                        {
+                                BOX_LOG_SYS_ERROR("Failed to read extended "
+                                        "attributes of " << Filename <<
+                                        ", not backed up");
+                                THROW_EXCEPTION(CommonException, OSFileError);
+                        }
                 }
         }