Changeset 2647 for box/trunk/bin/bbstored/HousekeepStoreAccount.cpp

Timestamp:

28/02/2010 16:31:27 (2 years ago)

Author:

chris

Message:

Build the reference counts for a directory before we start deleting
files, to ensure that it's initialized and memory allocated for it.

File:

• box/trunk/bin/bbstored/HousekeepStoreAccount.cpp (modified) (3 diffs)

box/trunk/bin/bbstored/HousekeepStoreAccount.cpp

@@ -421 +421 @@
                 mEmptyDirectories.push_back(dir.GetObjectID());
         }
-        
+
+        // Calculate reference counts first, before we start requesting
+        // files to be deleted.
+        // BLOCK
+        {
+                BackupStoreDirectory::Iterator i(dir);
+                BackupStoreDirectory::Entry *en = 0;
+
+                while((en = i.Next()) != 0)
+                {
+                        // This directory references this object
+                        if (mNewRefCounts.size() <= en->GetObjectID())
+                        {
+                                mNewRefCounts.resize(en->GetObjectID() + 1, 0);
+                        }
+                        mNewRefCounts[en->GetObjectID()]++;
+                }
+        }
+
         // BLOCK
         {
@@ -468 +486 @@
                 while((en = i.Next(BackupStoreDirectory::Entry::Flags_File)) != 0)
                 {
-                        // This directory references this object
-                        if (mNewRefCounts.size() <= en->GetObjectID())
-                        {
-                                mNewRefCounts.resize(en->GetObjectID() + 1, 0);
-                        }
-                        mNewRefCounts[en->GetObjectID()]++;
-
                         // Update recalculated usage sizes
                         int16_t enFlags = en->GetFlags();
@@ -583 +594 @@
                 while((en = i.Next(BackupStoreDirectory::Entry::Flags_Dir)) != 0)
                 {
-                        // This parent directory references this child
-                        if (mNewRefCounts.size() <= en->GetObjectID())
-                        {
-                                mNewRefCounts.resize(en->GetObjectID() + 1, 0);
-                        }
-                        mNewRefCounts[en->GetObjectID()]++;
-
                         // Next level
                         ASSERT((en->GetFlags() & BackupStoreDirectory::Entry::Flags_Dir) == BackupStoreDirectory::Entry::Flags_Dir);