Changeset 3069 for box/trunk/lib

Timestamp:

22/01/2012 16:39:12 (4 months ago)

Author:

chris

Message:

Catch trying to send a zero-length stream, which will cause an assertion failure on the other side.

File:

• box/trunk/lib/server/Protocol.cpp (modified) (1 diff)

box/trunk/lib/server/Protocol.cpp

@@ -688 +688 @@
                 // Can't send this using the fixed size header
                 uncertainSize = true;
+        }
+
+        if(streamSize == 0)
+        {
+                // Server protocol will throw an assertion failure if we
+                // try to send a stream whose size is definitely zero:
+                // ASSERT FAILED: [BytesToRead > 0] at PartialReadStream.cpp:31
+                // so catch this on the client side to help debugging
+                THROW_EXCEPTION_MESSAGE(ServerException, Protocol_BadUsage,
+                        "Sending a stream with a definite size of zero "
+                        "is not allowed in the protocol");
         }