Changeset 3078 for box/trunk

Timestamp:

02/02/2012 22:16:24 (4 months ago)

Author:

chris

Message:

Store more details in protocol exceptions to help with debugging.

File:

• box/trunk/lib/server/makeprotocol.pl.in (modified) (2 diffs)

box/trunk/lib/server/makeprotocol.pl.in

@@ -584 +584 @@
                 {
                         SetLastError(type, subType);
-                        BOX_WARNING(requestCommand << " command failed: "
+                        THROW_EXCEPTION_MESSAGE(ConnectionException,
+                                Conn_Protocol_UnexpectedReply,
+                                requestCommand << " command failed: "
                                 "received error " <<
                                 (($error_class&)rReply).GetMessage());
@@ -591 +593 @@
                 {
                         SetLastError(Protocol::UnknownError, Protocol::UnknownError);
-                        BOX_WARNING(requestCommand << " command failed: "
+                        THROW_EXCEPTION_MESSAGE(ConnectionException,
+                                Conn_Protocol_UnexpectedReply,
+                                requestCommand << " command failed: "
                                 "received unexpected response type " <<
                                 rReply.GetType());
                 }
-                
-                // Throw an exception
-                THROW_EXCEPTION(ConnectionException, Conn_Protocol_UnexpectedReply)
         }
 }