Changeset 906

Timestamp:

01/09/2006 00:31:38 (5 years ago)

Author:

chris

Message:

Use INVALID_SOCKET_VALUE instead of -1

File:

• box/chris/merge/lib/server/SocketStream.cpp (modified) (13 diffs)

box/chris/merge/lib/server/SocketStream.cpp

@@ -37 +37 @@
 // --------------------------------------------------------------------------
 SocketStream::SocketStream()
-        : mSocketHandle(-1),
+        : mSocketHandle(INVALID_SOCKET_VALUE),
           mReadClosed(false),
           mWriteClosed(false),
@@ -86 +86 @@
                 THROW_EXCEPTION(ServerException, BadSocketHandle);
         }
-        if(mSocketHandle == -1)
+        if(mSocketHandle == INVALID_SOCKET_VALUE)
         {
                 THROW_EXCEPTION(ServerException, DupError);
@@ -102 +102 @@
 SocketStream::~SocketStream()
 {
-        if(mSocketHandle != -1)
+        if(mSocketHandle != INVALID_SOCKET_VALUE)
         {
                 Close();
@@ -118 +118 @@
 void SocketStream::Attach(int socket)
 {
-        if(mSocketHandle != -1) {THROW_EXCEPTION(ServerException, SocketAlreadyOpen)}
+        if(mSocketHandle != INVALID_SOCKET_VALUE) 
+        {
+                THROW_EXCEPTION(ServerException, SocketAlreadyOpen)
+        }
 
         mSocketHandle = socket;
@@ -135 +138 @@
 void SocketStream::Open(int Type, const char *Name, int Port)
 {
-        if(mSocketHandle != -1) {THROW_EXCEPTION(ServerException, SocketAlreadyOpen)}
+        if(mSocketHandle != INVALID_SOCKET_VALUE) 
+        {
+                THROW_EXCEPTION(ServerException, SocketAlreadyOpen)
+        }
         
         // Setup parameters based on type, looking up names if required
@@ -145 +151 @@
         // Create the socket
         mSocketHandle = ::socket(sockDomain, SOCK_STREAM, 0 /* let OS choose protocol */);
-        if(mSocketHandle == -1)
+        if(mSocketHandle == INVALID_SOCKET_VALUE)
         {
                 THROW_EXCEPTION(ServerException, SocketOpenError)
@@ -159 +165 @@
                 ::close(mSocketHandle);
 #endif
-                mSocketHandle = -1;
+                mSocketHandle = INVALID_SOCKET_VALUE;
                 THROW_EXCEPTION(ConnectionException, Conn_SocketConnectError)
         }
@@ -175 +181 @@
 int SocketStream::Read(void *pBuffer, int NBytes, int Timeout)
 {
-        if(mSocketHandle == -1) {THROW_EXCEPTION(ServerException, BadSocketHandle)}
+        if(mSocketHandle == INVALID_SOCKET_VALUE) 
+        {
+                THROW_EXCEPTION(ServerException, BadSocketHandle)
+        }
 
         if(Timeout != IOStream::TimeOutInfinite)
@@ -248 +257 @@
 void SocketStream::Write(const void *pBuffer, int NBytes)
 {
-        if(mSocketHandle == -1) {THROW_EXCEPTION(ServerException, BadSocketHandle)}
+        if(mSocketHandle == INVALID_SOCKET_VALUE) 
+        {
+                THROW_EXCEPTION(ServerException, BadSocketHandle)
+        }
         
         // Buffer in byte sized type.
@@ -312 +324 @@
 void SocketStream::Close()
 {
-        if(mSocketHandle == -1) {THROW_EXCEPTION(ServerException, BadSocketHandle)}
+        if(mSocketHandle == INVALID_SOCKET_VALUE) 
+        {
+                THROW_EXCEPTION(ServerException, BadSocketHandle)
+        }
 #ifdef WIN32
         if(::closesocket(mSocketHandle) == -1)
@@ -321 +336 @@
                 THROW_EXCEPTION(ServerException, SocketCloseError)
         }
-        mSocketHandle = -1;
+        mSocketHandle = INVALID_SOCKET_VALUE;
 }
 
@@ -334 +349 @@
 void SocketStream::Shutdown(bool Read, bool Write)
 {
-        if(mSocketHandle == -1) {THROW_EXCEPTION(ServerException, BadSocketHandle)}
+        if(mSocketHandle == INVALID_SOCKET_VALUE) 
+        {
+                THROW_EXCEPTION(ServerException, BadSocketHandle)
+        }
         
         // Do anything?
@@ -389 +407 @@
 tOSSocketHandle SocketStream::GetSocketHandle()
 {
-        if(mSocketHandle == -1) {THROW_EXCEPTION(ServerException, BadSocketHandle)}
+        if(mSocketHandle == INVALID_SOCKET_VALUE) 
+        {
+                THROW_EXCEPTION(ServerException, BadSocketHandle)
+        }
         return mSocketHandle;
 }