bbackupd artificial block check prevents setting low or zero soft-limit

[gniemcew]

The "threshold for uploading new stuff" bbackupd artificial block check requires bbstored to maintain at least soft-limit plus 1/3 of soft/hard limit delta to attempt a backup, regardless of the (potentially smaller) new backup size. If the soft limit is set low (to retain few old/deleted blocks) or set to zero (to discard all old/deleted blocks on every housekeeping run), this check causes bbackupd to abandon a backup, even though there might be plenty of free blocks on a server. Attached patch changes the check in question to investigate a hard limit only.

[chris]

Ping on ticket 19? Any thoughts about whether we should apply these patches, or what a better solution would be?

This was discussed in the following broken thread:

 http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002032.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002034.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002037.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002042.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002047.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002063.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002066.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002070.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-January/002072.html  http://lists.warhead.org.uk/pipermail/boxbackup-dev/2007-February/002082.html

[chris]

(In [1659]) Apply Gary's patch from ticket #19 to respect the server's hard limit rather than the soft limit. This allows setting the soft limit to zero, so that housekeeping will remove all old versions of all files (refs #19)

[chris]

(In [1663]) New win32 native build (1662) with the following fixes and new features:

• Fix backup, restore and compare of files over 2 GB, hopefully ([1585], [1586], [1587], [1598], [1599], [1621], [1623])

• Log progress of large file backups at trace level ([1589], [1590])

• Notify (log) during full file uploads ([1594])

• Improve error messages in bbackupquery when comparing or getting a file fails with an exception ([1597], [1600])

• Improve error reporting in bbackupquery ([1638])

• Initialise logging framework and use for banner in bbackupquery ([1601], [1602])

• Include LICENSE.txt in binary package, but not Nick's old ReadMe?.txt ([1655])

• Save unused locations across bbackupd restarts, so that they will be deleted when their time is up, thanks to Gary ([1658], refs #18)

• Respect server hard limits rather than soft limits, to allow use of zero as a soft limit, thanks to Gary ([1659], [1662], refs #19)

• Fix restore to a directory under the root, with or without drive letter (c:\test\ or \test\), thanks to Mikael Syska ([1660], [1661])

[chris]

(In [1754]) Apply Gary's patch from ticket #19 to respect the server's hard limit rather than the soft limit. This allows setting the soft limit to zero, so that housekeeping will remove all old versions of all files. (refs #19, refs #3, merges [1659])

[chris]

Fixed by Gary's patch, thanks!