Changeset 2451

Timestamp:

15/03/2009 20:20:37 (18 months ago)

Author:

chris

Message:

Fix crash when freebsd (maybe *bsd) returns ECONNRESET on close(), which
presumably means that the socket is already closed, causing bbackupd test
to fail. Thanks to Victor Meirans for reporting the problem. See
 http://wiki.powerdns.com/cgi-bin/trac.fcgi/changeset/1280 and
 http://wiki.powerdns.com/cgi-bin/trac.fcgi/ticket/192 for example.

Files:

• box/trunk/lib/server/SocketStream.cpp (modified) (1 diff)

box/trunk/lib/server/SocketStream.cpp

@@ -369 +369 @@
         {
                 BOX_LOG_SYS_ERROR("Failed to close socket");
-                THROW_EXCEPTION(ServerException, SocketCloseError)
+                // don't throw an exception here, assume that the socket was
+                // already closed or closing.
         }
         mSocketHandle = INVALID_SOCKET_VALUE;